From e5461b1863982b3f5b040859bc8d2de4bd7c08a7 Mon Sep 17 00:00:00 2001
From: Eric Fischer <enf@pobox.com>
Date: Tue, 12 Apr 2016 16:40:03 -0700
Subject: [PATCH] Additional debug output from polygon checking

---
 geometry.cc | 52 ++++++++++++++++++++++++++++++++++++++++++++++------
 geometry.hh |  2 +-
 tile.cc     |  6 +++++-
 3 files changed, 52 insertions(+), 8 deletions(-)

diff --git a/geometry.cc b/geometry.cc
index 8966583a..a05086b8 100644
--- a/geometry.cc
+++ b/geometry.cc
@@ -368,6 +368,47 @@ nextring:
 	}
 }
 
+static void dump(drawvec &geom) {
+	ClipperLib::Clipper clipper(ClipperLib::ioStrictlySimple);
+
+	bool has_area = false;
+
+	for (size_t i = 0; i < geom.size(); i++) {
+		if (geom[i].op == VT_MOVETO) {
+			size_t j;
+			for (j = i + 1; j < geom.size(); j++) {
+				if (geom[j].op != VT_LINETO) {
+					break;
+				}
+			}
+
+			double area = get_area(geom, i, j);
+			if (area != 0) {
+				has_area = true;
+			}
+
+			ClipperLib::Path path;
+			printf("{ ClipperLib::Path path; ");
+
+			drawvec tmp;
+			for (size_t k = i; k < j; k++) {
+				printf("path.push_back(IntPoint(%lld,%lld)); ", geom[k].x, geom[k].y);
+				path.push_back(ClipperLib::IntPoint(geom[k].x, geom[k].y));
+			}
+
+			if (!clipper.AddPath(path, ClipperLib::ptSubject, true)) {
+			}
+			printf("clipper.AddPath(path, ClipperLib::ptSubject, true); ");
+
+			i = j - 1;
+		} else {
+			fprintf(stderr, "Unexpected operation in polygon %d\n", (int) geom[i].op);
+			exit(EXIT_FAILURE);
+		}
+		printf("clipper.Execute(ClipperLib::ctUnion, clipped)); }");
+	}
+}
+
 drawvec clean_or_clip_poly(drawvec &geom, int z, int detail, int buffer, bool clip) {
 	ClipperLib::Clipper clipper(ClipperLib::ioStrictlySimple);
 
@@ -479,7 +520,7 @@ static int pnpoly(drawvec &vert, size_t start, size_t nvert, long long testx, lo
 	return c;
 }
 
-void check_polygon(drawvec &geom) {
+void check_polygon(drawvec &geom, drawvec &before) {
 	for (size_t i = 0; i + 1 < geom.size(); i++) {
 		for (size_t j = i + 1; j + 1 < geom.size(); j++) {
 			if (geom[i + 1].op == VT_LINETO && geom[j + 1].op == VT_LINETO) {
@@ -493,12 +534,12 @@ void check_polygon(drawvec &geom) {
 				t = (s2_x * (geom[i + 0].y - geom[j + 0].y) - s2_y * (geom[i + 0].x - geom[j + 0].x)) / (-s2_x * s1_y + s1_x * s2_y);
 
 				if (t > 0 && t < 1 && s > 0 && s < 1) {
-					fprintf(stderr, "Internal error: self-intersecting polygon. %lld,%lld to %lld,%lld intersects %lld,%lld to %lld,%lld\n",
+					printf("Internal error: self-intersecting polygon. %lld,%lld to %lld,%lld intersects %lld,%lld to %lld,%lld\n",
 						geom[i + 0].x, geom[i + 0].y,
 						geom[i + 1].x, geom[i + 1].y,
 						geom[j + 0].x, geom[j + 0].y,
 						geom[j + 1].x, geom[j + 1].y);
-					exit(EXIT_FAILURE);
+						dump(before);
 				}
 			}
 		}
@@ -538,15 +579,14 @@ void check_polygon(drawvec &geom) {
 						}
 
 						if (!on_edge) {
-							fprintf(stderr, "%lld,%lld at %lld not in outer ring (%lld to %lld)", geom[k].x, geom[k].y, (long long) k, (long long) outer_start, (long long) (outer_start + outer_len));
+							printf("%lld,%lld at %lld not in outer ring (%lld to %lld)\n", geom[k].x, geom[k].y, (long long) k, (long long) outer_start, (long long) (outer_start + outer_len));
 
+							dump(before);
 #if 0
 							for (size_t l = outer_start; l < outer_start + outer_len; l++) {
 								fprintf(stderr, " %lld,%lld", geom[l].x, geom[l].y);
 							}
 #endif
-
-							fprintf(stderr, "\n");
 						}
 					}
 				}
diff --git a/geometry.hh b/geometry.hh
index 2831eb7e..6f2a9636 100644
--- a/geometry.hh
+++ b/geometry.hh
@@ -30,4 +30,4 @@ drawvec simplify_lines(drawvec &geom, int z, int detail);
 drawvec reorder_lines(drawvec &geom);
 drawvec fix_polygon(drawvec &geom);
 std::vector<drawvec> chop_polygon(std::vector<drawvec> &geoms);
-void check_polygon(drawvec &geom);
+void check_polygon(drawvec &geom, drawvec &before);
diff --git a/tile.cc b/tile.cc
index e8f64842..53e6821d 100644
--- a/tile.cc
+++ b/tile.cc
@@ -537,9 +537,13 @@ void *partial_feature_worker(void *v) {
 			// Scaling may have made the polygon degenerate.
 			// Give Clipper a chance to try to fix it.
 			for (size_t i = 0; i < geoms.size(); i++) {
+				drawvec before;
+				if (additional[A_DEBUG_POLYGON]) {
+					before = geoms[i];
+				}
 				geoms[i] = clean_or_clip_poly(geoms[i], 0, 0, 0, false);
 				if (additional[A_DEBUG_POLYGON]) {
-					check_polygon(geoms[i]);
+					check_polygon(geoms[i], before);
 				}
 				geoms[i] = close_poly(geoms[i]);
 			}